-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiation of Multidimensional Arrays in SINDyDerivative #476
Differentiation of Multidimensional Arrays in SINDyDerivative #476
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 94.68% 94.42% -0.27%
==========================================
Files 38 38
Lines 4105 4069 -36
==========================================
- Hits 3887 3842 -45
- Misses 218 227 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks Yash! Don't worry about code coverage, this looks like it passes CI. I just want to make the test a little bit more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Yash, thanks for making work on this. A few tips to make it work like a proper test
LGTM, but we'll wait to merge it until the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Yash!
This PR addresses the issue and lets SINDyDerivative handle arrays with more dimensions than 2.