Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm installation with tracing.enabled == false spams logs with tracing errors #54

Closed
W3D3 opened this issue Jul 6, 2023 · 1 comment · Fixed by #55
Closed

Helm installation with tracing.enabled == false spams logs with tracing errors #54

W3D3 opened this issue Jul 6, 2023 · 1 comment · Fixed by #55
Labels
bug Something isn't working

Comments

@W3D3
Copy link
Contributor

W3D3 commented Jul 6, 2023

Environment

  • Kubuntu 22.04.2 LTS x86_64
  • Unguard v0.8.1

When installing unguard using the new helm method, when not specifying the tracing profile for skaffold (or just generally not setting the tracing.enabled helm value to true), this results in some services trying to write traces, but failing to do so due to wrong/missing config.
The observed services that spammed their logs with tracing-related error messages were:

  • microblog-service
  • proxy-service

To Reproduce
Run skaffold run without any arguments and observe the logs of microblog-service and proxy-service

Expected behavior
I would expect none of the services to attempt to write traces if tracing.enabled is set to false.

Screenshots
Logs of the microblog-service attempting to write traces and failing:
image
Logs of the proxy-service attempting to write traces and failing:
image

Additional context
Example from proxy-service.yaml shows that we do not set any tracing related env vars of tracing.enabled being false, which results in the default behaviour:
image

@MfCrizz
Copy link
Contributor

MfCrizz commented Jul 9, 2023

With PR #55 the expected behavior is restored.
No more tracing-related error messages:

  • microblog-service
    image
  • proxy-service
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants