Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(tracing): Add missing default env variables to services #55

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

MfCrizz
Copy link
Contributor

@MfCrizz MfCrizz commented Jul 9, 2023

Some environment variables regarding tracing were not present in the tracing=disable state, causing exceptions in the microblog and proxy service.
This PR implements all tracing variables in the same behavior as with skaffold.

Fixes #54

Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess this sets some redundant env vars now, but I don't think that's a big deal.

chart/templates/ad-service.yaml Show resolved Hide resolved
chart/templates/frontend.yaml Show resolved Hide resolved
chart/templates/microblog-service.yaml Show resolved Hide resolved
@MfCrizz MfCrizz merged commit 10373d5 into main Jul 11, 2023
@MfCrizz MfCrizz deleted the bugfix/helm-tracing-not-fully-disabled branch July 11, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm installation with tracing.enabled == false spams logs with tracing errors
2 participants