Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Make user simulator a CronJob #29

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

W3D3
Copy link
Contributor

@W3D3 W3D3 commented Feb 2, 2023

Fixes #28.

This PR changes the benign load generation approach, by making the user-simulator pod run as a CronJob once every 3 minutes.

This change should lead to no more OOMKills of the user-simulator on the K8s side.

W3D3 added 3 commits February 2, 2023 11:24
…every 3 minutes

* This should fix the OOMKills, as the pods are only active for a short time and scheduling is performed by K8s
@W3D3 W3D3 requested a review from a team as a code owner February 2, 2023 11:55
@W3D3
Copy link
Contributor Author

W3D3 commented Feb 2, 2023

FYI chose to use GitMoji for the commit messages, I think it could make it a lot easier spotting the intention of a commit if we make it required for the future, also including the service that the commit affects.

Copy link
Contributor

@AlejandroCamba AlejandroCamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@W3D3 W3D3 merged commit 6807c78 into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods of user-simulator get OOMKilled
2 participants