Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kind cluster setup docs and fix dead link in code comment #67

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Update kind cluster setup docs and fix dead link in code comment #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
560ba5d
📝 docs: Update kind cluster setup docs
olivier97 Nov 7, 2023
cab248d
💡 fix(k8s-manifests): Update dead link in code comment
olivier97 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/DEV-GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This document explains how to build and run Unguard locally inside Kubernetes us
kind create cluster --name unguard --config ./k8s-manifests/localdev/kind/cluster-config.yaml
```

* Optionally add an nginx ingress controller if you want to expose Unguard locally without port-forwarding
* Also, make sure to deploy an nginx ingress controller so that Unguard can be exposed locally (without port-forwarding)
```sh
kubectl apply -k ./k8s-manifests/localdev/kind/
```
Expand Down
2 changes: 1 addition & 1 deletion k8s-manifests/localdev/kind/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resources:
- https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.2.1/deploy/static/provider/kind/deploy.yaml

# make this the default ingress class so that we don't have to annotate it explicitly
# see https://kubernetes.github.io/ingress-nginx/#i-have-only-one-ingress-controller-in-my-cluster-what-should-i-do
# see https://kubernetes.github.io/ingress-nginx/user-guide/k8s-122-migration/#i-have-only-one-ingress-controller-in-my-cluster-what-should-i-do
patchesStrategicMerge:
- |-
apiVersion: networking.k8s.io/v1
Expand Down
Loading