feat(then): ✨ cast big and float and add cast on schemas in the then phase #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #527 |
|
Merge carefully. There is a main difference between zenroom in this PR and in main. On main when printing a encoded table (e.g. base64 dictionary) that contains some floats/integers the floats/integers inside it are printed as floats/integers, here they are printed following the table encoding (e.g. as base64) |
|
needs some extra checks and maybe corrections for the eth and bitcoin examples. |
…tion This seems handly during debug, moreover negative big (as it is now) can not be encoded in the default encoding and could result in errors when printing out error messagges or using I.spy inside the code
as it was before when printing a encoded table (e.g. string dictionary) that was containing some floats the floats inside it where printed as floats, now they are printed following the table encoding (e.g. as strings)
…coding is mantained
Also update ZEN.assert and ZEN.CODEC to zencode_assert and CODEC
This is done beacuse everything can be encoded in integer while it is not true with numbers
matteo-cristino
force-pushed
the
fix/then_integers
branch
from
3df0832 to
445e3a3
Compare
jaromil
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #627