Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print line number of ignored statements #739

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Conversation

jaromil
Copy link
Member

@jaromil jaromil commented Oct 2, 2023

This adds the line number of zencode that aren't recognized and eventually ignored by the parser.

Line number excluded rules and scenario directives.

Tests aren't yet fixed, pending review.

@jaromil
Copy link
Member Author

jaromil commented Oct 2, 2023

@jaromil @albertolerda as you wished, pending your review and update of tests

@jaromil jaromil marked this pull request as ready for review October 11, 2023 19:59
@jaromil jaromil force-pushed the feat/ignored-line-num branch from e642ab1 to a8398de Compare October 11, 2023 20:00
linenum is the actual line number in the file

typo in newline
signal failure with zencode line and reason, better formatting

still some tests need updating the assert
also using error inside main ZEN:parse function to block execution

fix tests for new error codes

improve partial line parsing in many tests

python and js bindings update error log test
@jaromil jaromil force-pushed the feat/ignored-line-num branch from 920ca0b to 58789fb Compare October 12, 2023 20:47
@jaromil jaromil merged commit 3b10b98 into master Oct 12, 2023
35 checks passed
@jaromil jaromil deleted the feat/ignored-line-num branch October 12, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant