kpatch: better support for livepatch modules #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpoimboe
reviewed
Dec 20, 2016
| if [[ ! -z $checksum ]] && [[ -e "$SYSFS/${modname}/checksum" ]] ; then | ||
| sysfs_checksum=$(cat $SYSFS/${modname}/checksum) | ||
| [[ $checksum == $sysfs_checksum ]] || return 1 | ||
| fi |
There was a problem hiding this comment.
Bash functions return the return the result of the last command -- in this case, the "if; fi" construct. It would probably be safer to explicitly return 0 at the end of the function.
There was a problem hiding this comment.
Good catch, fixed in v2
| @@ -27,6 +27,14 @@ INSTALLDIR=/var/lib/kpatch | |||
| SCRIPTDIR="$(readlink -f $(dirname $(type -p $0)))" | |||
| VERSION="0.3.4" | |||
|
|
|||
| # Assume livepatch core is built into the kernel, otherwise | |||
| # use kpatch model. | |||
There was a problem hiding this comment.
Reworded in v2
Livepatch modules can be supported with minimal changes to the kpatch script. Adjust for appropriate sysfs paths, core-patching code (in kernel for livepatch, kpatch.ko for kpatch), and checksum verification (only verify the checksum if it exists). Fixes dynup#479.
joe-lawrence
force-pushed
the
livepatch_compat
branch
from
bbcaae4
to
b55dfb7
Compare
|
v2 - reworded live/kpatch comment, explicitly return 0 from |
|
👍 |
|
Thanks @joe-lawrence! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Livepatch modules can be supported with minimal changes to the kpatch
script. Adjust for appropriate sysfs paths, core-patching code (in
kernel for livepatch, kpatch.ko for kpatch), and checksum verification
(only verify the checksum if it exists).
Fixes #479.