-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap some methods directly in R #152
Comments
This comment has been minimized.
This comment has been minimized.
Wouter and I discussed this in person; it's a good idea to have dynmethods support a few methods out of the box without having to install docker, though I think submitting cran should have a higher priority. |
https://github.com/dynverse/dynmethods/tree/scorpius_package is a first attempt at doing this. When a user runs |
This comment has been minimized.
This comment has been minimized.
You can find an example at https://github.com/dynverse/ti_scorpius/tree/package definition.yml and example.sh are symlinked. This seemed to me the cleanest way of putting these both in the root directory and the package directory. The definition.yml contains a "package" section, which describes the package. The only place that this is really used is in dynmethods. Testing is included inside the package but this can be quite verbose because I don't want to depend directly dyntoy. So the example dataset is generated first using the package/tests/generate_test_data.sh script which calls the package/inst/example.sh scripts which saves an hdf5 file inside package/inst/example.h5 which is used for testing. Not ideal, perhaps we should depend on dyntoy... Otherwise, most things are pretty clean, e.g. the run.R directly calls the run function of the package, the version number is extracted from the DESCRIPTION, etc Any recommendations @rcannood ? |
dyntoy is now in suggests, which cleans up the testing quite a bit! dynverse/ti_scorpius@0cc4d8a |
We don't want to make this list too long, as this will make it hard to maintain in the long run.
Current shortlist:
The text was updated successfully, but these errors were encountered: