Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): token never expiration #716

Merged
merged 4 commits into from
Jun 27, 2023
Merged

feat(web): token never expiration #716

merged 4 commits into from
Jun 27, 2023

Conversation

robot9706
Copy link
Contributor

Added 'Never' option for user API tokens.

@robot9706 robot9706 requested a review from a team as a code owner June 26, 2023 13:22
@robot9706 robot9706 self-assigned this Jun 26, 2023
@github-actions github-actions bot added pr:feat lang:sql lang:typescript source:web The scope of the issue or pull request is web. labels Jun 26, 2023
polaroi8d
polaroi8d approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor remark, but LGTM.

@polaroi8d polaroi8d merged commit d9fd728 into develop Jun 27, 2023
25 checks passed
@polaroi8d polaroi8d deleted the feat/token-expiration-never branch June 27, 2023 13:34
robot9706 added a commit that referenced this pull request Jun 28, 2023
@robot9706
feat(web): token never expiration (#716)
8a38562
@gerimate gerimate mentioned this pull request Jul 6, 2023
Open
@gerimate gerimate linked an issue Jul 6, 2023 that may be closed by this pull request
Continuous Delivery capabilities #629
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@robot9706 robot9706

Labels
lang:sql lang:typescript pr:feat severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continuous Delivery capabilities
2 participants
@robot9706 @polaroi8d