Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add working directory to container config #879

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Nov 3, 2023

Add working dyrectory as a container option.

@m8vago m8vago requested a review from a team as a code owner November 3, 2023 15:56
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript lang:sql labels Nov 3, 2023
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang source:proto Protobuf related changes. labels Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ebb7051) 26.16% compared to head (d4c59b0) 26.12%.
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #879      +/-   ##
===========================================
- Coverage    26.16%   26.12%   -0.05%     
===========================================
  Files           70       70              
  Lines         7429     7438       +9     
===========================================
- Hits          1944     1943       -1     
- Misses        5332     5341       +9     
- Partials       153      154       +1     
Files Coverage Δ
golang/api/v1/deploy.go 80.61% <ø> (ø)
golang/pkg/dagent/utils/docker.go 3.02% <0.00%> (-0.01%) ⬇️
golang/pkg/crane/k8s/deployment.go 14.87% <0.00%> (-0.04%) ⬇️
golang/internal/mapper/grpc.go 80.91% <0.00%> (-0.49%) ⬇️
golang/pkg/builder/container/container_builder.go 71.03% <25.00%> (-0.52%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m8vago m8vago merged commit 94407f4 into develop Nov 6, 2023
26 checks passed
@m8vago m8vago deleted the feat/working-drectory branch November 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang lang:sql lang:typescript pr:feat source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants