Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container expected state #891

Merged
merged 15 commits into from
Jan 31, 2024
Merged

feat: container expected state #891

merged 15 commits into from
Jan 31, 2024

Conversation

robot9706
Copy link
Contributor

@robot9706 robot9706 commented Dec 7, 2023

Add option to specify a successful deployment condition for each image. These options are the container states shown on the deployment instance list, with an extra option to define an exit code for the Exited state.

@robot9706 robot9706 self-assigned this Dec 7, 2023
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript lang:sql source:proto Protobuf related changes. pr:feat labels Dec 7, 2023
@robot9706 robot9706 force-pushed the feat/expected-state branch 4 times, most recently from 84283b2 to f1a69c5 Compare December 8, 2023 10:02
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (dc7e91a) 18.12% compared to head (3ff7fc4) 17.98%.

Files Patch % Lines
golang/pkg/dagent/utils/docker.go 0.00% 86 Missing ⚠️
golang/internal/mapper/grpc.go 0.00% 20 Missing and 1 partial ⚠️
web/crux/src/grpc/protobuf/proto/agent.ts 9.09% 20 Missing ⚠️
web/crux/src/app/image/image.mapper.ts 0.00% 8 Missing ⚠️
web/crux/src/app/container/container.dto.ts 0.00% 5 Missing ⚠️
golang/pkg/crane/crux/watch.go 0.00% 3 Missing ⚠️
golang/pkg/crane/k8s/deploy_facade.go 0.00% 3 Missing ⚠️
web/crux/src/domain/validation.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #891      +/-   ##
===========================================
- Coverage    18.12%   17.98%   -0.14%     
===========================================
  Files          345      345              
  Lines        17266    17401     +135     
  Branches      1013     1019       +6     
===========================================
+ Hits          3129     3130       +1     
- Misses       13949    14082     +133     
- Partials       188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robot9706 robot9706 marked this pull request as ready for review December 8, 2023 12:49
@robot9706 robot9706 requested a review from a team as a code owner December 8, 2023 12:49
@robot9706 robot9706 marked this pull request as draft December 11, 2023 12:19
@robot9706 robot9706 force-pushed the feat/expected-state branch 2 times, most recently from 2b82c31 to e1c061c Compare December 20, 2023 15:22
@robot9706 robot9706 marked this pull request as ready for review December 21, 2023 09:53
Copy link
Contributor

@m8vago m8vago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the docker config section.
Also please add a configuration option for timeout.

@polaroi8d
Copy link
Collaborator

Please fill out the pull request description.

@robot9706 robot9706 marked this pull request as draft January 4, 2024 09:46
@robot9706 robot9706 force-pushed the feat/expected-state branch 4 times, most recently from 3e61963 to 12a87d5 Compare January 9, 2024 13:46
@robot9706 robot9706 marked this pull request as ready for review January 9, 2024 15:01
@m8vago m8vago marked this pull request as draft January 10, 2024 10:34
@robot9706 robot9706 marked this pull request as ready for review January 10, 2024 11:08
@robot9706 robot9706 requested a review from m8vago January 31, 2024 12:55
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, apart from that single unused variable.

golang/pkg/crane/k8s/deploy_facade.go Outdated Show resolved Hide resolved
@polaroi8d polaroi8d merged commit 6c64c54 into develop Jan 31, 2024
26 checks passed
@polaroi8d polaroi8d deleted the feat/expected-state branch January 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang lang:sql lang:typescript pr:feat severity:medium source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants