-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: container expected state #891
Conversation
84283b2
to
f1a69c5
Compare
f1a69c5
to
808538a
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #891 +/- ##
===========================================
- Coverage 18.12% 17.98% -0.14%
===========================================
Files 345 345
Lines 17266 17401 +135
Branches 1013 1019 +6
===========================================
+ Hits 3129 3130 +1
- Misses 13949 14082 +133
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
d085804
to
2bbe4c9
Compare
2b82c31
to
e1c061c
Compare
e1c061c
to
709dcec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to the docker config section.
Also please add a configuration option for timeout.
Please fill out the pull request description. |
3e61963
to
12a87d5
Compare
12a87d5
to
f444c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, apart from that single unused variable.
Add option to specify a successful deployment condition for each image. These options are the container states shown on the deployment instance list, with an extra option to define an exit code for the
Exited
state.