Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container log api #931

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: container log api #931

merged 2 commits into from
Mar 11, 2024

Conversation

robot9706
Copy link
Contributor

Add REST APIs for container logs.

@robot9706 robot9706 self-assigned this Mar 8, 2024
@robot9706 robot9706 requested a review from a team as a code owner March 8, 2024 09:05
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:golang lang:typescript pr:feat labels Mar 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 17.95%. Comparing base (2d22943) to head (9b7d017).

Files Patch % Lines
web/crux/src/app/node/node.service.ts 14.28% 12 Missing ⚠️
golang/internal/grpc/grpc.go 0.00% 5 Missing ⚠️
.../app/node/node.global-container.http.controller.ts 0.00% 2 Missing ⚠️
.../app/node/node.prefix-container.http.controller.ts 0.00% 2 Missing ⚠️
web/crux/src/domain/container-log-stream.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #931      +/-   ##
===========================================
- Coverage    17.96%   17.95%   -0.01%     
===========================================
  Files          346      346              
  Lines        17429    17454      +25     
  Branches      1020     1021       +1     
===========================================
+ Hits          3131     3134       +3     
- Misses       14109    14131      +22     
  Partials       189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for further approval from @nandor-magyar for minor questions / requests.

web/crux/src/app/node/node.service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706 robot9706 merged commit e831ffa into develop Mar 11, 2024
26 checks passed
@robot9706 robot9706 deleted the feat/log-api branch March 11, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants