Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s.io/client-go to v0.26.0 #7

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Bump k8s.io/client-go to v0.26.0 #7

merged 2 commits into from
Jan 9, 2023

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Dec 30, 2022 •
edited
Loading

Hi team,

Please help to review my MR.

Goal: we want to upgrade Keda to use client-go v0.26.0 and Keda is using this library as a dependency

A few things I want to highlight in here:

unsafe.Slice requires go1.17 or later
  • Please let me know whether you want reproducibility with go 1.16 or not. Currently I'm going with the former option below:
To upgrade to the versions selected by go 1.16:
        go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
        go mod tidy -compat=1.17

@dttung2905 dttung2905 mentioned this pull request Jan 7, 2023
Open
@daniel-yavorovich daniel-yavorovich merged commit 5a82fcc into dysnix:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dttung2905 @daniel-yavorovich