Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Sftp source and Prefect tasks #1039

Merged
merged 43 commits into from
Sep 27, 2024
Merged

✨ Add Sftp source and Prefect tasks #1039

merged 43 commits into from
Sep 27, 2024

Conversation

Diego-H-S
Copy link
Collaborator

Summary

SFTP connector migration from viadot 1 to viadot 2.

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Diego-H-S Diego-H-S mentioned this pull request Sep 18, 2024
3 tasks
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
tests/integration/orchestration/prefect/flows/test_sftp.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/sftp_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at them.

Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the feedback still needs to be addressed, otherwise I think 90% is either done or requires an issue to be created & linked.

src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Show resolved Hide resolved
tests/integration/orchestration/prefect/flows/test_sftp.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/sftp_to_adls.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
src/viadot/sources/sftp.py Outdated Show resolved Hide resolved
@Rafalz13
Copy link
Contributor

Tests are in progress. @trymzet please take a look at the code.

Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor things left. Also, pls make sure that CI passes before requesting PR, otherwise it's added work for me since I need to look at the same PR twice.

pyproject.toml Outdated Show resolved Hide resolved
tests/unit/test_sftp.py Outdated Show resolved Hide resolved
@trymzet trymzet changed the title Sftp 2.0 ✨ Add Sftp source and Prefect tasks Sep 27, 2024
@trymzet trymzet merged commit 3de17df into 2.0 Sep 27, 2024
3 checks passed
@trymzet trymzet deleted the sftp_2.0 branch September 27, 2024 13:12
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants