Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add CustomerGauge source and Prefect tasks #1040

Merged
merged 27 commits into from
Sep 27, 2024
Merged

Conversation

Diego-H-S
Copy link
Collaborator

Summary

Customer Gauge connector migration from viadot 1 to viadot 2. Also added some utility functions into viadot utils.

issue: #904

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

CHANGELOG.md Outdated Show resolved Hide resolved
src/viadot/utils.py Outdated Show resolved Hide resolved
src/viadot/utils.py Outdated Show resolved Hide resolved
src/viadot/utils.py Show resolved Hide resolved
src/viadot/utils.py Show resolved Hide resolved
src/viadot/sources/customer_gauge.py Outdated Show resolved Hide resolved
src/viadot/sources/customer_gauge.py Outdated Show resolved Hide resolved
tests/unit/test_customer_gauge.py Outdated Show resolved Hide resolved
src/viadot/sources/customer_gauge.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at it.

Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things left

pyproject.toml Outdated Show resolved Hide resolved
trymzet

This comment was marked as outdated.

@trymzet trymzet changed the title Customer gauge 2.0 Add CustomerGauge source, and Prefect tasks Sep 27, 2024
@trymzet trymzet changed the title Add CustomerGauge source, and Prefect tasks ✨ Add CustomerGauge source, and Prefect tasks Sep 27, 2024
@trymzet trymzet changed the title ✨ Add CustomerGauge source, and Prefect tasks ✨ Add CustomerGauge source and Prefect tasks Sep 27, 2024
@trymzet trymzet merged commit eb29241 into 2.0 Sep 27, 2024
3 checks passed
@trymzet trymzet deleted the customer_gauge_2.0 branch September 27, 2024 09:44
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants