Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add BusinessCore source and Prefect tasks #1051

Merged
merged 23 commits into from
Oct 4, 2024
Merged

Conversation

judynah
Copy link

@judynah judynah commented Sep 24, 2024

Summary

Business Core connector migration from viadot 1 to viadot 2. Added verify parameter into utility functions.

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Copy link

gitguardian bot commented Sep 24, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6616985 Triggered Generic Password 883b504 tests/integration/test_business_core.py View secret
6616985 Triggered Generic Password 883b504 tests/integration/test_business_core.py View secret
6616985 Triggered Generic Password 1920067 tests/integration/test_business_core.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@trymzet
Copy link
Contributor

trymzet commented Sep 24, 2024

@judynah pls fix the linter errors before requesting review. You can ignore the test_handle_api_request() test failing as it's a known issue.

Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI not passing so not ready for review

@trymzet trymzet changed the title ✨ Added Business Core connector, task and flow ✨ Add BusinessCore source and Prefect tasks Sep 27, 2024
@Rafalz13 Rafalz13 requested a review from trymzet October 1, 2024 07:21
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my feedback

src/viadot/orchestration/prefect/tasks/business_core.py Outdated Show resolved Hide resolved
src/viadot/sources/business_core.py Outdated Show resolved Hide resolved
src/viadot/sources/business_core.py Outdated Show resolved Hide resolved
src/viadot/sources/business_core.py Outdated Show resolved Hide resolved
src/viadot/sources/business_core.py Outdated Show resolved Hide resolved
src/viadot/sources/business_core.py Outdated Show resolved Hide resolved
@trymzet trymzet merged commit df931e2 into 2.0 Oct 4, 2024
3 checks passed
@trymzet trymzet deleted the business_core_2.0 branch October 4, 2024 14:59
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants