-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Raise ValueError
if response is empty in CouldForCustomers
source
#900
Draft
adrian-wojcik
wants to merge
5
commits into
dyvenia:dev
Choose a base branch
from
adrian-wojcik:c4c_empty_response_handle
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1cb1a4b
Merge pull request #892 from dyvenia/dev
Rafalz13 4fb0132
🚀 Added new error handling if response is empty with tests and entry …
fdd604d
🎨 Changed Error message
cf5a845
🎨 Changed enrty in changelog
61ba65a
♻️ Change to logic of rising error if there is empty output from conn…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,6 @@ def _to_records_report(self, url: str) -> List[Dict[str, Any]]: | |
records.extend(new_records) | ||
|
||
url = response_json["d"].get("__next") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please consider to use solution from this code: |
||
|
||
return records | ||
|
||
def _to_records_other(self, url: str) -> List[Dict[str, Any]]: | ||
|
@@ -222,6 +221,11 @@ def to_df( | |
""" | ||
records = self.to_records() | ||
df = pd.DataFrame(data=records, **kwargs) | ||
|
||
if df.empty: | ||
raise ValueError( | ||
"Response from cloud for customers for specified parameters were empty!" | ||
) | ||
if dtype: | ||
df = df.astype(dtype) | ||
if fields: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description doesn't match with code modification