Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Add add-build-ignore command to gommon #105

Closed
at15 opened this issue Dec 30, 2018 · 0 comments
Closed

[cmd] Add add-build-ignore command to gommon #105

at15 opened this issue Dec 30, 2018 · 0 comments
Assignees
@at15
Labels
area/go pkg/cmd type/new-feature
Milestone
0.0.9

Comments

@at15
Copy link
Member

at15 commented Dec 30, 2018 •
edited
Loading

This is needed to add // +build !ignore to all the files in the legacy folder so they are ignored by go tool chain

gommon add-build-ignore ./legacy/requests
@at15 at15 added this to the 0.0.9 milestone Dec 30, 2018
@at15 at15 self-assigned this Dec 30, 2018
at15 added a commit that referenced this issue Dec 30, 2018
@at15
[go] Init go.mod #74 for using replace
23165f6 
- for using local version of gommon, users need to use the replace
directive and use a relative local path, this requires gommon to have a
go mod file, otherwise it won't work
- [ ] TODO: add ignore tag for legacy packages #105
at15 added a commit that referenced this issue Dec 30, 2018
@at15
[cmd] Add add-build-ignore Fix #105
db40028
at15 added a commit that referenced this issue Dec 30, 2018
@at15
[legacy] Ignore legacy pkgs using build tag #105
ebd4181 
- this also removed pkg/errors from go.mod #74
@at15 at15 added the area/go label Dec 30, 2018
@at15 at15 closed this as completed Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at15 at15

Labels
area/go pkg/cmd type/new-feature
Projects
None yet
Milestone
0.0.9
Development

No branches or pull requests
1 participant
@at15