Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[error] Align interface with official implementation golang/xerrors #109

Closed
2 tasks done
at15 opened this issue Feb 9, 2019 · 2 comments
Closed
2 tasks done

[error] Align interface with official implementation golang/xerrors #109

at15 opened this issue Feb 9, 2019 · 2 comments
Labels
area/go pkg/errors
Milestone
0.0.13

Comments

@at15
Copy link
Member

at15 commented Feb 9, 2019 •
edited
Loading

https://github.com/golang/xerrors

This repository holds the transition packages for the new Go 1.13 error values

gommon/errors should keep same interface so migrating to standard library is easier
@at15 at15 added this to the 0.0.10 milestone Feb 9, 2019
@at15
Copy link
Member Author

at15 commented Apr 13, 2019

It is already in dev tree, also it is using reflectlite (which is internal) https://github.com/golang/go/tree/master/src/errors I am not sure if gommon/errors is still needed in that case ....

@at15 at15 modified the milestones: 0.0.10, 0.0.12 Apr 13, 2019
@at15 at15 mentioned this issue Apr 13, 2019
Open
5 tasks
at15 added a commit that referenced this issue Jan 18, 2020
@at15
[errors] Support go1.13 As #109
f00a153
@at15 at15 modified the milestones: 0.0.13, 0.0.14 Jan 18, 2020
@at15
Copy link
Member Author

at15 commented Jan 18, 2020

Fixed in #119

@at15 at15 closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/go pkg/errors
Projects
None yet
Milestone
0.0.13
Development

No branches or pull requests
1 participant
@at15