Parameter 'req' can be declared as pointer to const [constParameterPo…

…inter] int comms_control_handler(ControlPacket_t *req, uint8_t *resp) /home/dzid_/openpilot/panda/board/flasher.h:7:44: style
dzid26 · Jun 6, 2024 · 8d31590 · 8d31590
1 parent 7442f78
commit 8d31590
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/board/comms_definitions.h b/board/comms_definitions.h
@@ -5,7 +5,7 @@ typedef struct {
   uint16_t length;
 } __attribute__((packed)) ControlPacket_t;
 
-int comms_control_handler(ControlPacket_t *req, uint8_t *resp);
+int comms_control_handler(const ControlPacket_t *req, uint8_t *resp);
 void comms_endpoint2_write(const uint8_t *data, uint32_t len);
 void comms_can_write(const uint8_t *data, uint32_t len);
 uint32_t comms_can_read(uint8_t *data, uint32_t max_len);

diff --git a/board/flasher.h b/board/flasher.h
@@ -4,7 +4,7 @@ bool unlocked = false;
 
 void spi_init(void);
 
-int comms_control_handler(ControlPacket_t *req, uint8_t *resp) {
+int comms_control_handler(const ControlPacket_t *req, uint8_t *resp) {
   int resp_len = 0;
 
   // flasher machine

diff --git a/board/jungle/main_comms.h b/board/jungle/main_comms.h
@@ -36,7 +36,7 @@ void comms_endpoint2_write(const uint8_t *data, uint32_t len) {
   UNUSED(len);
 }
 
-int comms_control_handler(ControlPacket_t *req, uint8_t *resp) {
+int comms_control_handler(const ControlPacket_t *req, uint8_t *resp) {
   unsigned int resp_len = 0;
   uint32_t time;
 

diff --git a/board/main_comms.h b/board/main_comms.h
@@ -64,7 +64,7 @@ void comms_endpoint2_write(const uint8_t *data, uint32_t len) {
   }
 }
 
-int comms_control_handler(ControlPacket_t *req, uint8_t *resp) {
+int comms_control_handler(const ControlPacket_t *req, uint8_t *resp) {
   unsigned int resp_len = 0;
   uart_ring *ur = NULL;
   uint32_t time;