tres: fix SOM reset line blinking (commaai#2003)

Co-authored-by: Comma Device <device@comma.ai>
dzid26 · Aug 23, 2024 · e53c802 · e53c802
1 parent 080e53f
commit e53c802
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/board/boards/cuatro.h b/board/boards/cuatro.h
@@ -85,8 +85,8 @@ void cuatro_init(void) {
   set_gpio_pullup(GPIOC, 2, PULL_DOWN);
 
   // SOM bootkick + reset lines
-  set_gpio_mode(GPIOC, 12, MODE_OUTPUT);
   tres_set_bootkick(BOOT_BOOTKICK);
+  set_gpio_mode(GPIOC, 12, MODE_OUTPUT);
 
   // SOM debugging UART
   gpio_uart7_init();

diff --git a/board/boards/tres.h b/board/boards/tres.h
@@ -42,8 +42,9 @@ void tres_init(void) {
   set_gpio_pullup(GPIOC, 2, PULL_DOWN);
 
   // SOM bootkick + reset lines
-  set_gpio_mode(GPIOC, 12, MODE_OUTPUT);
+  // WARNING: make sure output state is set before configuring as output
   tres_set_bootkick(BOOT_BOOTKICK);
+  set_gpio_mode(GPIOC, 12, MODE_OUTPUT);
 
   // SOM debugging UART
   gpio_uart7_init();