✨ Allow empty site description #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshy7
force-pushed
the
AllowEmptySiteDescription
branch
from
dd50f0d to
89d522d
Compare
|
Hi, can you please add a test for this fix? I.e. add the description attribute to the tests and remove it in a later step. The testing framework then detects non-empty plans. To test locally, you can just temporarily comment your fix. Your test should then fail. Then uncomment the fix and it should pass. |
Currently, site that has been previously configured with a description can no longer be cleared out. Even if the terraform configuration indicates empty or nil description, the change will not be persisted to NSOT. Additionally, every time a terraform plan is run, it will always detect an update-in-place for this field. This change fixes this behavior by setting site description's to space character. This is based on the pattern on other existing resource such as network device. Also added TestAccNetboxSite_fieldUpdate() test to test updates on fields. References: - fbreckle/go-netbox#25 - https://github.com/e-breuninger/terraform-provider-netbox/blob/master/netbox/resource_netbox_device.go#L331
keshy7
force-pushed
the
AllowEmptySiteDescription
branch
from
89d522d to
b0f8560
Compare
|
Thank you for this check, @fbreckle! I found an issue in my previous code because of the test. The changes are now in. Thank you once again for your kind direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, site that has been previously configured with a description can no longer be cleared out. Even if the terraform configuration indicates empty or nil description, the change will not be persisted to NSOT. Additionally, every time a terraform plan is run, it will always detect an update-in-place for this field.
This change fixes this behavior by setting site description's to space character. This is based on the pattern on other existing resource such as network device.
References: