Add support for physical and shipping address in sites

[Ikke]

No description provided.

[fbreckle]

Looks good so far. Can you add a test that also unsets the fields and see if that works? You might have to set the string to ' ' to unset it.

[Ikke]

@fbreckle I adjusted it to use the same approach as description. I assume you are aware that setting it explicitly to an empty string in terraform would not work due to the omitempty on those fields in get-netbox library

[fbreckle]

Yes, but a single space is not an empty string :D

[Ikke]

Yes, but a single space is not an empty string :D

Yes, indeed 🙂. So this solution works when you leave out the field, but doing something like

resource "netbox_site" "test" {
  name             = "test"
  physical_address = ""
}

will not update physical address, and

resource "netbox_site" "test" {
  name             = "test"
  physical_address = " "
}

will keep showing up as a change (as netbox trims the field).

It's just something practitioners need to be aware of.

[fbreckle]

I suppose that applies to the other string fields where it is implemented like that as well? No issue on my side.

[Ikke]

I suppose that applies to the other string fields where it is implemented like that as well? No issue on my side.

Yes, that would apply there as well.