Add data-source for ipam role and support for route targets #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbreckle
requested changes
Feb 22, 2023
|
Hi, this is looking pretty good already. I added some notes, which should be rather easy to fix for you if you got this far. |
fix acctest resolve git comments
imdhruva
force-pushed
the
add_ds_for_ipam_role_and_support_for_route_targets
branch
from
c499555 to
bfcc0f3
Compare
imdhruva
force-pushed
the
add_ds_for_ipam_role_and_support_for_route_targets
branch
from
6bc4387 to
11ad259
Compare
|
@fbreckle bumping for a review and merge. 🙇 |
fbreckle
approved these changes
Mar 20, 2023
twink0r
pushed a commit
to twink0r/terraform-provider-netbox
that referenced
this pull request
Sep 15, 2023
…nger#344) * add support for ipam_role and route_targets * fix acctest * add support for ipam_role and route_targets fix acctest resolve git comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.