-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rack Support #358
Rack Support #358
Conversation
pushed an update to fix the device rack functionality when a rack is cleared out after being set let me know once the netbox client PR is merged and I can update the Also note that |
not sure why the code is failing to build for the tests given that it seems to work fine locally with the same go.mod as on git |
7c1a665
to
a3a05c2
Compare
rebased to master and fixed the issue caused by the merge, hopefully should work now |
Looks like tests fail on older versions of netbox which don't support the new attributes added in API 3.4. I think those attributes are primarily metadata, so I can remove them from the tests unless you have any suggestions? |
Since this patch contains content that is useful for 3.3 users, I think we should for now continue supporting that version. |
return strVal | ||
} | ||
|
||
func getOptionalVal[SchemaT int | float64, ApiT int64 | float64](d *schema.ResourceData, key string) *ApiT { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL Go now has generics 😮
Closes #352
New resources:
New data sources:
Adds support for referencing rack and rack location in a netbox_device resource and data source
Depends on fbreckle/go-netbox#27, tests will break until merged. Tests will also break in master if the go-netbox changes are merged without this PR (specifically commit
minimal updates to API 3.4
).Added minimal support for API version 3.4 to ensure that current functionality remains the same