Feature Additon: Contact Group resource and data source

[leasley199]

Adds the following:

Data Source:

• Contacts
• Contact Groups

Resource:

• Contact Groups

Currently the the contact module has a call out for group_id but no method to get/create the contact group. One would have to hardcode the group_id value. Adds the missing pieces to the provider.

Examples:

# Create contact_group called test department
resource "netbox_contact_group" "main" {
  name = "test department"
}

# Get data of contact_group test department
data "netbox_contact_group" "main" {
  name = "test deparment"
}

# Create netbox_contact with group_id from data.netbox_contact_group
resource "netbox_contact" "main" {
  name = "test contact"
  group_id = data.netbox_contact_group.main.id
}

# Get Data on netbox_contact
data "netbox_contact" "test" {
  name = "Test  Contact"
}

[leasley199]

ready for workflow task, tested locally with make testacc and received a successful run.

[jantari]

A netbox_contact data source would be really good to have for us so we can assign owners to resources from terraform.

@fbreckle Is there any chance this PR can be moved aloong? Thank you

[fbreckle]

Well, last time a test failed. This must be fixed. The original author seems to have abandoned the issue, do you want to take it up?

[jantari]

I don't have permissions to push to their fork / branch and therefore directly contribute to this PR but what about this?

Suggested change

	"netbox_contact_group": resourceNetboxContact(),
	"netbox_contact_group": resourceNetboxContactGroup(),

[fbreckle]

Oh right. My bad :D

As for the change you mentioned: Yes, that seems to be wrong, but the tests fail for another reason.

I will look into this MR later (tm).

[leasley199]

Hello, sorry got busy with other items and put this on the back-burn. Yea can't seem to find out why the changes fail testing. If you cowboy it with a live deployment they are succesful..

[fbreckle]

I don't want to tell how long I debugged until I found in wireshark that the HTTP calls are made to /contacts instead of /contact-groups.
Then I was like "damn, I remember this". D'oh! 🙈 :D

Merge is now underway. No clue how the tests suite passes locally.

Fun fact: It does not pass locally if you only run the single test via -run TestAccNetboxContactGroupDataSource_basic to the go test make target.