Support tag and status filters for netbox_prefixes data source #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
tag
andstatus
values as filters for the existingnetbox_prefixes
data source.This PR also suggests removing the requirement that the data source must return at least 1 prefix as a result, and instead allows it to support returning 0 results:
There seems to be some inconsistency across the data sources in regards to this behavior - some data sources support returning 0 results, and others don't.
I'll defer to the maintainers on whether or not we can remove the above check, but IMO, the provider should not error out of a plan just because a particular data source might return 0 results (especially since the Netbox API itself support this).
If a user has a requirement that a data source must return results, then IMO they should implement logic locally to account for that rather than having the provider force the behavior.