Support site_id as filter type for data_source_netbox_prefixes #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbreckle - simple PR to add support for a filter we need. Thanks for reviewing! |
|
Please include the functionality in a test |
We need the ability to filter prefixes on their site_id. This adds the functionality that is documented in netbox here: http://localhost:8001/api/schema/swagger-ui/#/ipam/ipam_prefixes_list Added testing to validate the filtering by site_id works as expected
|
@fbreckle I have updated the tests to account for this new filter. |
Added additional description fields with information about filters and the filter types that are currently supported.
|
The ci tests fail randomly sometimes. force pushing an amended commit to hopefully fix. |
|
Checks passing. @fbreckle - ready for final review. |
|
Are you able to merge this one as well @fbreckle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to filter prefixes on their site_id. This adds the functionality that is documented in netbox here: http://localhost:8001/api/schema/swagger-ui/#/ipam/ipam_prefixes_list