fix: add vm context field to primary_ip update func #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbreckle - small fix for local context bug. |
tagur87
force-pushed
the
primary-ip-context
branch
from
682c2a8 to
e8c98b1
Compare
|
Please add a test that fails without the fix. This way we can confirm that the change is actually needed and the chance for future regressions is reduced. Edit: In this case, by "add", I mean "edit an existing test to cover the changed attribute" |
tagur87
force-pushed
the
primary-ip-context
branch
from
e8c98b1 to
2795f44
Compare
fbreckle
reviewed
Jul 24, 2023
@fbreckle - sorry about missing that. I have added a test now that should cover this usage in the primary_ip resource. |
tagur87
force-pushed
the
primary-ip-context
branch
from
2795f44 to
4a53a5b
Compare
fbreckle
reviewed
Jul 24, 2023
When the local context was added to the vm resource, the fields were not added to the primary ip update function, which caused the local context field to be unset when the `resource_netbox_primary_ip` resource was used. Add extra test to ensure converage and prevent regression in the future.
tagur87
force-pushed
the
primary-ip-context
branch
from
4a53a5b to
6cd5462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the local context was added to the vm resource, the fields were not added to the primary ip update function, which caused the local context field to be unset when the
resource_netbox_primary_ipresource was used.