Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set deviceInterfaceId from device_interface_id #437

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

switchcorp
Copy link

Fix wrong attribute used to set deviceInterfaceId

@fbreckle
Copy link
Collaborator

fbreckle commented Jul 24, 2023

Whops. Looks like a copy n paste error. Do you have example code that fails due to this? I'm wondering because the tests all succeed.

@fbreckle fbreckle merged commit 072f52a into e-breuninger:master Jul 24, 2023
@switchcorp
Copy link
Author

This morning I did a refactoring of our code to use device_interface_id and virtual_machine_interface_id instead of interface_id. In most of the cases, I had a change linked to the update of the attribute in the state and everything was ok.

What I did notice, is that for my baremetal servers, I lost the link between the ip addresses and the device (breaking our ansible inventory). When I checked the changelog of the interface, I saw that the link to the device was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants