Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new resource for webhook #438

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

haipersuccor02
Copy link
Contributor

@haipersuccor02 haipersuccor02 commented Jul 24, 2023

This resource will allow to configure netbox webhook. This will allows us to configure webhook to Microsoft teams messages if new sites are being added to netbox or removed.

Test Result:

🚀 Netbox is up and running!
⌛ Startup acceptance tests on http://localhost:8001/
TF_ACC=1 go test -run TestAccNetBoxWebhook_basic -v -cover netbox/.go
=== RUN TestAccNetBoxWebhook_basic
=== PAUSE TestAccNetBoxWebhook_basic
=== CONT TestAccNetBoxWebhook_basic
--- PASS: TestAccNetBoxWebhook_basic (1.05s)
PASS
command-line-arguments coverage: 3.7% of statements
ok command-line-arguments 2.618s coverage: 3.7% of statements
TF_ACC=1 go test -run TestAccNetboxWebhook_update -v -cover netbox/.go
=== RUN TestAccNetboxWebhook_update
=== PAUSE TestAccNetboxWebhook_update
=== CONT TestAccNetboxWebhook_update
--- PASS: TestAccNetboxWebhook_update (1.43s)
PASS
command-line-arguments coverage: 4.2% of statements
ok command-line-arguments 2.810s coverage: 4.2% of statements
TF_ACC=1 go test -run TestAccNetboxWebhook_import -v -cover netbox/*.go
=== RUN TestAccNetboxWebhook_import
=== PAUSE TestAccNetboxWebhook_import
=== CONT TestAccNetboxWebhook_import
--- PASS: TestAccNetboxWebhook_import (0.92s)
PASS
command-line-arguments coverage: 3.7% of statements
ok command-line-arguments 2.294s coverage: 3.7% of statements

A dependency PR/MR for model is here : fbreckle/go-netbox#31

@fbreckle
Copy link
Collaborator

I rebased this and used the go-netbox client from the feature/webhooks branch as mentioned in fbreckle/go-netbox#31 (comment)

@haipersuccor02 haipersuccor02 marked this pull request as ready for review August 22, 2023 08:31
@haipersuccor02
Copy link
Contributor Author

Thanks @fbreckle :)

@haipersuccor02 haipersuccor02 changed the title Create a new resource for webhook Draft: Create a new resource for webhook Aug 25, 2023
@haipersuccor02 haipersuccor02 marked this pull request as draft August 25, 2023 07:13
@fbreckle fbreckle force-pushed the create-new-webhook branch from e9ec58d to d08fe7e Compare August 31, 2023 12:20
@fbreckle fbreckle force-pushed the create-new-webhook branch from d08fe7e to 2ec04f2 Compare August 31, 2023 12:31
@fbreckle fbreckle marked this pull request as ready for review August 31, 2023 12:46
@fbreckle fbreckle changed the title Draft: Create a new resource for webhook Create a new resource for webhook Aug 31, 2023
@fbreckle fbreckle merged commit be09a26 into e-breuninger:master Aug 31, 2023
twink0r pushed a commit to twink0r/terraform-provider-netbox that referenced this pull request Sep 15, 2023
* Create a new resource for webhook

* Use Webhook instead of WritableWebhook

* Add webhook.md

* Update

---------

Co-authored-by: Fabian Breckle <fabian.breckle@breuninger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants