Added netbox_location datasource #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add tests for the new datasource. See other singular datasources for examples. If you need help, ping me. |
Added filtering by location_id and rack_id
fbreckle
force-pushed
the
feature/locations
branch
from
5b7f912 to
68d8d79
Compare
|
I implemented the test and found a bug. Hooray for tests! |
twink0r
pushed a commit
to twink0r/terraform-provider-netbox
that referenced
this pull request
Sep 15, 2023
* Added netbox_location datasource Added filtering by location_id and rack_id * test: Add tests for location datasource * fix(test): Use correct attribute for site_id in location datasource --------- Co-authored-by: Danil Tolkalin <dtolkalin@t1-cloud.ru> Co-authored-by: Fabian Breckle <fabian.breckle@breuninger.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added netbox_location datasource
Added filtering by location_id and rack_id for netbox_device