-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature fields interfaces #469
Feature fields interfaces #469
Conversation
5708396
to
785c34f
Compare
Hi, thanks for your MR! For fields that reference other objects, I prefer the attributes to reflect the type of the referenced object. I.e. |
785c34f
to
5a46cb0
Compare
Fixed the naming as you wished. Found a bug by myself. (LAG was saved in Parent field). Albeit using the code, did not catch this error. Have to write tests for this. |
5a46cb0
to
b0900a0
Compare
b0900a0
to
ea4ebe6
Compare
ea4ebe6
to
fdd50cf
Compare
This took a while. I'm not familiar with golang at all. But finally, it works properly:
Please have a look at the tests, if these are missing. Anything else missing? Thank you for fixing the ASN stuff and also adding |
fyi: You should not change the docs directly, since they are autogenerated. I made 5911b2f to match your doc updates. Docs can be generated with |
Oh, I understand. Thank you! |
This adds multiple useful fields to netbox_device_interface.