Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parent_prefix to filter #485

Merged
merged 2 commits into from
Oct 20, 2023
Merged

feat: add parent_prefix to filter #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87becdc
feat: add parent_prefix to filter
sjurtf Oct 13, 2023
703943b
fix: add test
sjurtf Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netbox/data_source_netbox_ip_addresses.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ func dataSourceNetboxIPAddressesRead(d *schema.ResourceData, m interface{}) erro
params.Vrf = &vString
case "tenant":
params.Tenant = &vString
case "parent_prefix":
params.Parent = &vString
default:
return fmt.Errorf("'%s' is not a supported filter parameter", k)
}
Expand Down
44 changes: 44 additions & 0 deletions netbox/data_source_netbox_ip_addresses_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,50 @@ data "netbox_ip_addresses" "test_list" {
})
}

func TestAccNetboxIpAddressesDataSource_filter_parent_prefix(t *testing.T) {
testSlug := "ipam_ipaddrs_ds_filter_prefix"
testName := testAccGetTestName(testSlug)
testPrefix1 := "203.0.113.0/24"
testIP0 := "203.0.113.1/24"
testIP1 := "203.0.200.1/24"
resource.Test(t, resource.TestCase{
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: testAccNetboxIPAddressFullDependencies(testName) + fmt.Sprintf(`
resource "netbox_prefix" "testv4" {
prefix = "%s"
status = "active"
}
resource "netbox_ip_address" "test_list_0" {
ip_address = "%s"
virtual_machine_interface_id = netbox_interface.test.id
status = "active"
tags = [netbox_tag.test.name]
}
resource "netbox_ip_address" "test_list_1" {
ip_address = "%s"
virtual_machine_interface_id = netbox_interface.test.id
status = "active"
tags = [netbox_tag.test.name]
}
data "netbox_ip_addresses" "test_list" {
depends_on = [netbox_ip_address.test_list_0, netbox_ip_address.test_list_1]

filter {
name = "parent_prefix"
value = "%s"
}
}`, testPrefix1, testIP0, testIP1, testPrefix1),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.netbox_ip_addresses.test_list", "ip_addresses.#", "1"),
resource.TestCheckResourceAttrPair("data.netbox_ip_addresses.test_list", "ip_addresses.0.ip_address", "netbox_ip_address.test_list_0", "ip_address"),
),
},
},
})
}

func TestAccNetboxIpAddressesDataSource_multiple(t *testing.T) {
testSlug := "ipam_ipaddrs_ds_multiple"
testIP0 := "203.0.113.1/24"
Expand Down