Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add filter for status in virtual machines data source #612

Merged
merged 4 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netbox/data_source_netbox_virtual_machines.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ func dataSourceNetboxVirtualMachineRead(d *schema.ResourceData, m interface{}) e
case "tag":
tags = append(tags, vString)
params.Tag = tags
case "status":
params.Status = &vString
default:
return fmt.Errorf("'%s' is not a supported filter parameter", k)
}
Expand Down
80 changes: 80 additions & 0 deletions netbox/data_source_netbox_virtual_machines_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,29 @@ func TestAccNetboxVirtualMachinesDataSource_tags(t *testing.T) {
})
}

func TestAccNetboxVirtualMachinesDataSource_status(t *testing.T) {
testSlug := "vm_ds_status"
testName := testAccGetTestName(testSlug)
dependencies := testAccNetboxVirtualMachineDataSourceDependenciesWithStatus(testName)
resource.Test(t, resource.TestCase{
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: dependencies,
},
{
Config: dependencies + testAccNetboxVirtualMachineDataSourceStatusActive + testAccNetboxVirtualMachineDataSourceStatusDecommissioning,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.netbox_virtual_machines.test_active", "vms.#", "1"),
resource.TestCheckResourceAttr("data.netbox_virtual_machines.test_decommissioning", "vms.#", "1"),
resource.TestCheckResourceAttrPair("data.netbox_virtual_machines.test_active", "vms.0.status", "netbox_virtual_machine.test0", "status"),
resource.TestCheckResourceAttrPair("data.netbox_virtual_machines.test_decommissioning", "vms.0.status", "netbox_virtual_machine.test1", "status"),
),
},
},
})
}

func testAccNetboxVirtualMachineDataSourceDependencies(testName string) string {
return testAccNetboxVirtualMachineFullDependencies(testName) + fmt.Sprintf(`
resource "netbox_virtual_machine" "test0" {
Expand Down Expand Up @@ -250,3 +273,60 @@ data "netbox_virtual_machines" "tag-ab" {
}
}`, testName)
}

const testAccNetboxVirtualMachineDataSourceStatusActive = `
data "netbox_virtual_machines" "test_active" {
filter {
name = "status"
value = "active"
}
}`

const testAccNetboxVirtualMachineDataSourceStatusDecommissioning = `
data "netbox_virtual_machines" "test_decommissioning" {
filter {
name = "status"
value = "decommissioning"
}
}`

func testAccNetboxVirtualMachineDataSourceDependenciesWithStatus(testName string) string {
return testAccNetboxVirtualMachineFullDependencies(testName) + fmt.Sprintf(`
resource "netbox_tag" "servicea" {
name = "%[1]s_service-a"
}

resource "netbox_virtual_machine" "test0" {
name = "%[1]s_0"
cluster_id = netbox_cluster.test.id
site_id = netbox_site.test.id
comments = "thisisacomment"
memory_mb = 1024
disk_size_gb = 256
tenant_id = netbox_tenant.test.id
role_id = netbox_device_role.test.id
platform_id = netbox_platform.test.id
vcpus = 4
status = "active"
tags = [
netbox_tag.servicea.name,
]
}

resource "netbox_virtual_machine" "test1" {
name = "%[1]s_1"
cluster_id = netbox_cluster.test.id
site_id = netbox_site.test.id
comments = "thisisacomment"
memory_mb = 1024
disk_size_gb = 256
tenant_id = netbox_tenant.test.id
role_id = netbox_device_role.test.id
platform_id = netbox_platform.test.id
vcpus = 4
status = "decommissioning"
tags = [
netbox_tag.servicea.name,
]
}`, testName)
}