Support generic prompted auth #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the file names to be consistent with 134aa5b
The prompt string for a simple one-value "token" or "email" can now be configured. So we can use it for both "dummy-dev" and "token-list" modes, AND the text can be in various languages if needed. The files were renamed in 134aa5b This is the actual changes to read the prompt and pass it in to the javascript, which now takes the prompt as an argument.
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Sep 20, 2018
- add a sample for `openid` - add a sample for `token_list` - update all samples from `dummy-dev` to `prompted-auth` (consistent with e-mission/cordova-jwt-auth#28 and e-mission/cordova-jwt-auth#32) Update README to clarify + point to revised docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the prompt was hard-coded to "Dummy dev auth" (left), which is an issue when it is used for token-based authentication. Now, the prompt can be configured so that if token based authentication is used, the prompt can say "Enter token" (right).