Improve ios onboarding #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For iOS 13+, it is easier if the app launches the settings page to set always, instead of the convoluted process we had earlier. We can also check to see if the value is "Always" and prompt the user on app launch if it is not. + Unify the alerting mechanisms between location and motion activity, prior to improving the checks for motion activity.
Concretely: - consolidate almost all checking code into `TripDiarySettingsCheck` - call it from `BEMDataCollection`, `TripDiaryDelegate`, `TripDiaryStateMachine` - enhance checks for motion and fitness - add checks for precise location
shankari
added a commit
to shankari/cordova-server-sync
that referenced
this pull request
Jun 2, 2021
I think that the activity sync class as a whole should move into the data collection plugin, but that is an argument for a different day. This is the last part or the little spur of the refactoring in e-mission/e-mission-data-collection#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.