Handle android 11 "always" permission properly + Humanize android notification messages #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly, the "In state %s" message is now changed to localizable strings such as "Ready to start trip". @PatGendre, you might want to localize these as well to remove the remaining english text in your app :)
…tion permission This makes it easier to set the permissions instead of having people select "when in use" first and then have to go to the app settings later to fix it. This fixes e-mission/e-mission-docs#608 at least for now
The most common messages displayed by the foreground service are the "In state XXX" message. But the state is too jargon-y - e.g. "In state local.state.waiting_for_trip_start". It could also not be easily internationalized. Based on feedback from the Smart Commute program, we changed this to more meaningful messages. I'd been putting this off because it is a bit tricky to do. We have the state as a string. But the i18n solution maps from an id to the humanized string. So how do I convert a string to an ID? It turned out to not be that hard. https://stackoverflow.com/a/29902630/4040267 https://stackoverflow.com/a/19093447/4040267
Remove all references to "email" since we now "upload" logs + shorten some strings
Follow on to e24462e Was ignored initially because I removed all imports to avoid the package renames
So that we can re-check and ensure that the user used the appropriate settings
Testing done:
- on android 29, ensured that the original in-line prompt was displayed
- on android 30,
- launch the settings, user doesn't change anything, come back to app, error
about location permission, click
- launch the settings again, user switches to "when in use", come back to
app, error about background permission, click
- launch the settings again, user switches to "always", come back to app, no
additional errors, now in waiting_for_trip_start
This is a follow on to e-mission@e24462e
Since the app settings screen does not have an output
|
Re-testing done on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes e-mission/e-mission-docs#608