✓ Updated "Verify Inference" Checkmark #1047
Conversation
See [Issue e-mission#979](e-mission/e-mission-docs#979 (comment)) for more details. Only slight difference in comment; removed the `-0.2rem` in this commit, the buttons look crowded otherwise.
Updated the button to only appear if you can verify the trip. Button color now matches the "inferred trip" data.
See conversation in PR `rem` doesn't work properly in react-native, updated Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>
iconButtonProp & Border Color Changed prop to use native property, adjusted border color. Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>
|
@the-bay-kay Can you move this into "Ready for review" on https://github.com/orgs/e-mission/projects/1/views/1 ? |
| disabled={trip.verifiability != 'can-verify'} | ||
| style={{width: 20, height: 20, margin: 3}}/> | ||
| </View> | ||
| {trip.verifiability === 'can-verify' && ( |
There was a problem hiding this comment.
@the-bay-kay I see that this logic is unmodified, so I am going to merge it. But I would like to understand what it does, maybe illustrated with a short video.
From the code, it looks like if either button is yellow, we can "confirm" it. So if I had one yellow label and one blank label, I could press the confirm button and it would turn the yellow -> blue but leave the blank label unchanged.
Is that correct?
There was a problem hiding this comment.
My apologies for the late reply! Here are two videos, comparing the old UI and the changes this added.
beforeVerify.mov
VerificationCheckmark.mp4
Work discussed in Issue 979 !