Cherry-pick the walkthrough changes to master #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See e-mission/e-mission-docs#669. This should hopefully be a fix, but the problem occurs so inconsistently that I can't be sure. Steps taken: + Select walkthrough targets by ID + Remove incorrect use of IDs to make room for correct use of IDs + Use mildly hacky CSS to exclude DOM elements that have been translated to negative X, which often happens with the duplicated ones + Scroll back down only at the end of the walkthrough so we can back to the previous step more often + Fix walkthrough launch button padding Testing done: + Tested on an emulated iPhone 8 logged in with my real stage token - I had previously often been able to reproduce the problem under these conditions, and now I'm not seeing the problem, but it could just happen to not be appearing
Albeit in a lamer fashion. The problem is that there are multiple elements with the same ID in the list. We could consider switching to a more sophisticated walkthrough solution. However, for now, we just step out to the full list of trips instead of highlighting individual items. This seems to work pretty reliably, let's push it to staging and see if it works.
|
@GabrielKS "worse quality but not broken" fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #795
which got messed up with a bunch of unrelated commits.
The walkthrough now works on both physical android and physical iOS, even after hitting the refresh button.
It highlights the entire list instead of individual list items since our current walkthrough doesn't work when there are multiple items with the same class or id.
nzTour is deprecated, so we should move to a new walkthrough mechanism anyway. We can take a look at what that mechanism supports and tighten up the walkthrough.
The build seems to be failing, but that should not be related to our changes since they are UI only.