Refresh the status checks before the status modal is opened #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shankari
commented
Feb 9, 2022
shankari
commented
- fix formatting for the mph values
Before this change, the status was only computed when the controller was initialized. This is fine for all permission related changes, since downgrading permissions causes the app to restart and the controller to get re-initialized. However, changing location settings does not cause the app to restart, and presumably other status checks might not as well. So if we initialize the controller (maybe with green values) and then fail the status again, then it stays green. The principled fix for this is probably a service, which will also allow us to read the status and change the color and icon accordingly. e-mission/e-mission-docs#680 (comment) But for now, a decoupled approach, with event-driven message passing is be a better option. We can revisit when we refactor the app status code into individual components. If we choose to keep an event-driven architecture, we can also use events to get the overall status back to the parent component.
Without this fix, the mph values had lots of decimal points. Note that we might not actually need to `parseFloat`, multiplying with numeric strings seems to work fine at least in chrome. ``` ic.getKmph(metersPerSecond) "10.80" KM_TO_MILES * ic.getKmph(metersPerSecond) 6.7108068 KM_TO_MILES * 10.80 6.710806 KM_TO_MILES * "3.1" 1.9262501 ``` But I presumably made the change for a reason, so let's be consistent throughout and change later if needed e-mission@98af95d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.