Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "second level of end checks" for the user label matching #815

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

shankari
Copy link
Contributor

As part of 3ec5734
we changed the input from a trip geojson to a trip object. But we forgot to
change one of the code paths, which caused a regression.

Fixed by changing the variable and the format of the variable.

Testing done:

  • loaded fake manual entries for a test user
  • before the change, got the error
  • after the change, did not get the error

This fixes e-mission/e-mission-docs#713

As part of e-mission@3ec5734
we changed the input from a trip geojson to a trip object. But we forgot to
change one of the code paths, which caused a regression.

Fixed by changing the variable and the format of the variable.

Testing done:
- loaded fake manual entries for a test user
- before the change, got the error
- after the change, did not get the error

This fixes e-mission/e-mission-docs#713
@shankari shankari merged commit 69683e1 into e-mission:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code error while retrieving trips from the server
1 participant