Minor fit and finish issues, primarily on iOS, but one for android #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the second issue in e-mission/e-mission-docs#722 (comment) In particular, we add the `viewport-fit=cover` tag. Unfortunately, since we are using ionic version 1, it doesn't automatically set all the safe areas correctly. So we had to figure out how to send them manually. Finally got it to work, applied it only to iOS e-mission/e-mission-docs#722 (comment) Both iOS and android work well now, at least in profile mode e-mission/e-mission-docs#722 (comment)
- notification check: e-mission-data-collection
e-mission/e-mission-docs#722 (comment)
- crashes e-mission-transition-notify, cordova-usercache
e-mission/e-mission-docs#722 (comment)
…reen This fixes e-mission/e-mission-docs#658 Thanks to @allenmichael099 for reporting a reproducible use case that I could fix in under an hour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes e-mission/e-mission-docs#722 and e-mission/e-mission-docs#658