stretchr#562: assert.NoError() and assert.Error() now behave correctl…

…y when a nil error struct is supplied
e-nikolov · Oct 3, 2019 · d1a1769 · d1a1769
1 parent 85f2b59
commit d1a1769
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/assert/assertions.go b/assert/assertions.go
@@ -1197,7 +1197,7 @@ func NoError(t TestingT, err error, msgAndArgs ...interface{}) bool {
 	if h, ok := t.(tHelper); ok {
 		h.Helper()
 	}
-	if err != nil {
+	if !isNil(err) {
 		return Fail(t, fmt.Sprintf("Received unexpected error:\n%+v", err), msgAndArgs...)
 	}
 
@@ -1215,7 +1215,7 @@ func Error(t TestingT, err error, msgAndArgs ...interface{}) bool {
 		h.Helper()
 	}
 
-	if err == nil {
+	if isNil(err)  {
 		return Fail(t, "An error is expected but got nil.", msgAndArgs...)
 	}