Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-check class based views from #1964 #2055

Closed
richardebeling opened this issue Oct 25, 2023 · 0 comments · Fixed by #2060
Closed

Type-check class based views from #1964 #2055

richardebeling opened this issue Oct 25, 2023 · 0 comments · Fixed by #2060
Assignees
Labels
[C] Tests and CI New or better testing and CI [P] Minor Minor priority [S] Small This issue should require only small changes.

Comments

@richardebeling
Copy link
Member

In #1964, we made a mistake with the instance variables and return types inside UserMergeSelectionView::get_success_url. Mypy didn't complain about these mistakes. I would have expected that the function signature of get_success_url from the base class is applied, but mypy doesn't do this.

To make mypy detect such errors, I think we want to type-annotate the class based views introduced in #1964 and possibly also mark them with the @override decorator.

@richardebeling richardebeling added [S] Small This issue should require only small changes. [C] Tests and CI New or better testing and CI labels Oct 25, 2023
@richardebeling richardebeling self-assigned this Oct 30, 2023
@janno42 janno42 added the [P] Minor Minor priority label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Tests and CI New or better testing and CI [P] Minor Minor priority [S] Small This issue should require only small changes.
Development

Successfully merging a pull request may close this issue.

2 participants