Type-check class based views from #1964 #2055
Labels
[C] Tests and CI
New or better testing and CI
[P] Minor
Minor priority
[S] Small
This issue should require only small changes.
In #1964, we made a mistake with the instance variables and return types inside
UserMergeSelectionView::get_success_url
. Mypy didn't complain about these mistakes. I would have expected that the function signature ofget_success_url
from the base class is applied, but mypy doesn't do this.To make mypy detect such errors, I think we want to type-annotate the class based views introduced in #1964 and possibly also mark them with the
@override
decorator.The text was updated successfully, but these errors were encountered: