-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to builtin generic views where appropriate #1964
Conversation
Linting is currently failing for some complicated views like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
Overall, I'd be fine with having grade upload remain a function-based view. From the current CI linting output:
I'd be fine with adding exceptions for these, i.e. telling pylint that
Why is that? What additional two arguments does |
a2f069d
to
0266e31
Compare
Lints are all fixed, reverted some views to functions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a quick glance, but I'll have to go through it carefully once more. You can rebase / prepare a merge if you want.
0266e31
to
aa4e39a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the forms are definitely more readable now
11c2493
to
140290a
Compare
Closes #1754