Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single results having their results hidden in evaluation_detail #1690

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

karyon
Copy link
Collaborator

@karyon karyon commented Jan 1, 2022

They were hidden for staff users if the results weren't published yet, which was not intended.

Fixes #1621

Staff users should be able to see the results even if they are unpublished.

Fixes e-valuation#1621
@karyon karyon force-pushed the fix_hidden_single_results branch from 3b1a94d to 897727a Compare January 1, 2022 14:28
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

@janno42 janno42 requested a review from richardebeling January 3, 2022 16:54
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

evap/results/tests/test_views.py Outdated Show resolved Hide resolved
@karyon karyon merged commit 7b72ffa into e-valuation:main Jan 4, 2022
@karyon karyon deleted the fix_hidden_single_results branch January 4, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Single results' results are hidden in course detail page if not published
4 participants