Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A notebook for EvaP #1771

Merged
merged 191 commits into from
Oct 10, 2023
Merged

A notebook for EvaP #1771

merged 191 commits into from
Oct 10, 2023

Conversation

fidoriel
Copy link
Collaborator

This is my approach for the notebook derived from @janno42 design study.
See issue #1760 for reference.

@fidoriel fidoriel marked this pull request as draft June 14, 2022 08:01
@fidoriel
Copy link
Collaborator Author

This still a draft. May @janno42 have a look at the front end implementation to greenlight it?

@janno42
Copy link
Member

janno42 commented Jun 20, 2022

Very nice! There are some (small) things that I want to address:

  • The opening animation should be smoother - we probably have to overwrite the Bootstrap animation.
  • The input field should not be resizable because it already fills the available space.
  • The heading and close button should have a smaller left and right padding so they align with the input field. The top and bottom padding can probably also be reduced.
  • The button to open the notebook should be placed on the top left, with the same distance to the top bar as the offcanvas.

richardebeling
richardebeling reviewed Jul 3, 2022
View reviewed changes
evap/context_processors.py Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/evaluation/templates/django/forms/widgets/textarea.html Outdated Show resolved Hide resolved
evap/evaluation/templates/notebook.html Outdated Show resolved Hide resolved
evap/evaluation/views.py Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
richardebeling
richardebeling reviewed Jul 19, 2022
View reviewed changes
evap/context_processors.py Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/evaluation/views.py Outdated Show resolved Hide resolved
evap/results/tests/test_views.py Outdated Show resolved Hide resolved
evap/evaluation/views.py Outdated Show resolved Hide resolved
evap/static/scss/components/_buttons.scss Outdated Show resolved Hide resolved
evap/static/scss/evap.scss Outdated Show resolved Hide resolved
fidoriel and others added 5 commits July 19, 2022 21:49
@fidoriel @richardebeling
Update evap/evaluation/templates/base.html
da311d1 
Co-authored-by: Richard Ebeling <dev@richardebeling.de>
@fidoriel @richardebeling
Update evap/evaluation/templates/base.html
9b4e989 
Co-authored-by: Richard Ebeling <dev@richardebeling.de>
@fidoriel @richardebeling
Update evap/results/tests/test_views.py
acb40ee 
Co-authored-by: Richard Ebeling <dev@richardebeling.de>
@fidoriel @richardebeling
Update evap/evaluation/templatetags/evaluation_filters.py
76aa9b2 
Co-authored-by: Richard Ebeling <dev@richardebeling.de>
@fidoriel @richardebeling
Update evap/evaluation/tests/test_views.py
5edea46 
Co-authored-by: Richard Ebeling <dev@richardebeling.de>
richardebeling
richardebeling reviewed Oct 2, 2023
View reviewed changes
evap/evaluation/urls.py Outdated Show resolved Hide resolved
evap/evaluation/templates/notebook.html Outdated Show resolved Hide resolved
evap/evaluation/templates/notebook.html Outdated Show resolved Hide resolved
evap/static/ts/src/notebook.ts Outdated Show resolved Hide resolved
evap/static/ts/src/notebook.ts Outdated Show resolved Hide resolved
janno42
janno42 reviewed Oct 9, 2023
View reviewed changes
evap/evaluation/templates/notebook.html Outdated Show resolved Hide resolved
evap/static/scss/components/_notebook.scss Outdated Show resolved Hide resolved
janno42
janno42 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

(on commit e36704e)

@richardebeling richardebeling self-requested a review October 9, 2023 18:22
niklasmohrin
niklasmohrin requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Final?) comments

evap/evaluation/urls.py Outdated Show resolved Hide resolved
evap/static/ts/src/notebook.ts Outdated Show resolved Hide resolved
evap/static/ts/src/notebook.ts Outdated Show resolved Hide resolved
evap/evaluation/templates/notebook.html Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin approved these changes Oct 10, 2023
View reviewed changes
evap/static/ts/src/notebook.ts Outdated Show resolved Hide resolved
@fidoriel @niklasmohrin
Update evap/static/ts/src/notebook.ts
a6b751d 
Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
@janno42 janno42 merged commit baaa7dd into e-valuation:main Oct 10, 2023
@janno42
Copy link
Member

janno42 commented Oct 10, 2023

Remember, remember, the 10th of ... October. 🎆

Thank you! :)

@janno42 janno42 mentioned this pull request Oct 10, 2023
Closed
@richardebeling richardebeling mentioned this pull request Feb 15, 2024
Closed
@niklasmohrin niklasmohrin mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fidoriel @janno42 @Kakadus @richardebeling @FranzSw @niklasmohrin