Allow running refresh_results_cache during normal operation, with each cache update happening atomically #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janno42
approved these changes
Aug 1, 2022
niklasmohrin
approved these changes
Aug 8, 2022
richardebeling
force-pushed
the
results-caching
branch
from
52bcf8a to
9507d41
Compare
niklasmohrin
reviewed
Aug 8, 2022
richardebeling
force-pushed
the
results-caching
branch
from
9507d41 to
34dca49
Compare
niklasmohrin
approved these changes
Aug 15, 2022
…h cache update happening atomically.
Removes the intermediate method that we had before which was already named update_template_cache.
richardebeling
force-pushed
the
results-caching
branch
from
34dca49 to
7dd7f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 to solving #1739. When adding a cronjob that regularly runs ./manage.py refresh_results_cache, this should make invalid cache entries fix themselves the next time the cronjob runs.
(Note: The results page will still be broken during the period after merging courses but before the next cronjob run. We probably want to add manual triggers for such cases.)